Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new InputObject parameter #262

Merged
merged 5 commits into from
Feb 28, 2020
Merged

new InputObject parameter #262

merged 5 commits into from
Feb 28, 2020

Conversation

nwls-hermesj
Copy link
Contributor

This PR includes changes to the Remove-GSDriveFile cmdlet, moving invariants to the Begin clause and introducing parameter sets. The new InputObject parameter provides for deleting either a File[] or pipelined File objects (from Get-GSDriveFileList, for example). The FileId parameter is made optional to preclude prompting. FileId and InputObject are mutually exclusive, but leaving both unset is okay - nothing happens.

@scrthq
Copy link
Member

scrthq commented Feb 19, 2020

Hey @nwls-hermesj - Thank you for submitting this! I should be able to review this shortly and I'll get this in with the next release. If there are any adjustments needed, I'll push them up to your source branch directly so they're rolled into this PR.

Getting caught up on backlog with PSGSuite now, thank you for your patience and again for your submission! 🙂

@scrthq scrthq self-assigned this Feb 19, 2020
@scrthq scrthq added this to the 2.36.0 milestone Feb 19, 2020
@scrthq
Copy link
Member

scrthq commented Feb 28, 2020

@nwls-hermesj - Made some adjustments to make better use of pipeline input, getting this merged!

@scrthq scrthq merged commit 166a23b into SCRT-HQ:master Feb 28, 2020
@scrthq scrthq mentioned this pull request Feb 28, 2020
scrthq added a commit that referenced this pull request Feb 28, 2020
## 2.36.0 - 2020-02-28

* [PR #255](#255) - _Thanks, [@FISHMANPET](https://github.com/FISHMANPET)!_
    * Added support for `[ScriptBlock]` values on the config, allowing you to provide a script to run that will pull in a configuration value (vs embedded the value directly on the config)
* [PR #255](#260) - _Thanks, [@vaskotoo](https://github.com/vaskotoo)!_
    * Added support for an array of Users on `Get-GSGmailMessageList`
* [PR #261](#261) - _Thanks, [@Foggy2](https://github.com/Foggy2)!_
    * Added support for all license types including undocumented ones.
    * Closed out [Issue #252](#252) as well.
* [PR #262](#262) - _Thanks, [@nwls-hermesj](https://github.com/nwls-hermesj)!_
    * Added support for pipeline input of Drive file objects to `Remove-GSDriveFile`.
* [Issue #256](#256)
    * Cleaned up docs on `Send-GSChatMessage`.
* [Issue #258](#258)
    * Removed URL Shortener functions due to Google deprecation.
* [Issue #263](#263)
    * Fixed `[SecureString]` decryption on Unix machines running PowerShell 7
* Miscellaneous
    * Removed the Tasks API functions. Google has not pushed an update to the Tasks .NET SDK in over 2 months, so it is now behind the current release versions of the core Google.Apis assemblies, resulting in failure to import.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants